[HarfBuzz] harfbuzz-ng: Branch 'master' - 5 commits

Behdad Esfahbod behdad at behdad.org
Thu Apr 29 16:50:10 PDT 2010


On 04/29/2010 07:40 PM, Jonathan Kew wrote:
> On 29 Apr 2010, at 19:32, Behdad Esfahbod wrote:
> 
>> +#if __GNUC__ >= 3
>> +#define HB_FUNC __PRETTY_FUNCTION__
>> +#elif defined(_MSC_VER)
>> +#define HB_FUNC __FUNCSIG__
>> +#else
>> +#define HB_FUNC __func__
>> +#endif
> 
> Doesn't this need to test whether __GNUC__ is defined, before comparing its value? E.g.

Undefined identifiers default to 0.  Also, if the expression in an #if is not
well-formed, it resolves to false...  So, should be fine.

behdad



More information about the HarfBuzz mailing list