[HarfBuzz] [PATCH] Move two-way glib script conversion functions to be private

[Tom Hacohen]

Dear all,

>From the patch's commit log:
I guess there are uses for exposing those, though if really wanted, we
should probably add a "hb-glib-utils.h" file and not include it in
hb-glib.h.
Rationale: users of Harfbuzz may want to use the glib unicode functions
but don't want to work against glib itself (e.g they don't have the glib
headers in their system).

In the project I'm working on for example, we are only using the glib
unicode functions in the meanwhile and it's just annoying to add special
checks to see if glib is present in the system and if so add it's
cflags. With this patch I can just check for availability of hb-glib.h
and get done with it."


Btw, what about adding a function that just returns the preferred
unicode functions no matter what's installed? Fairly easy to implement,
just define an precedence and:
#ifdef HB_GLIB
return get_glib_funcs....
#elif defined(HB_ICU)
return get_icu_funcs...
...
#endif

I guess users of the API don't really care where they get their unicode
funcs from (I know I don't care) and this will make harfbuzz a lot
easier to work with.

What do you think?
Tom.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-glib-Move-two-way-script-conversion-functions-to-be-.patch
Type: text/x-patch
Size: 1716 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/harfbuzz/attachments/20110421/6365f7e6/attachment.bin>