[HarfBuzz] Classic Mongolian in Firefox

[Jonathan Kew]

I've had a bug on file about updating harfbuzz in our tree for awhile now... https://bugzilla.mozilla.org/show_bug.cgi?id=695857. I'm about to post updated patches there, as we've had other code changes in the meantime that require some revision; then let's hope we can get it reviewed and landed.

Behdad, if you could take a couple of patches upstream in harfbuzz (so that we don't have to make local modifications), that'd be helpful:

(1) some older/stricter compilers don't accept a trailing comma in enums, so please eliminate those;

(2) the loop-indexing fixes from https://bugzilla.mozilla.org/show_bug.cgi?id=701637, plus correction from bug 714067.

I'm attaching patches for these issues that should be easy to apply upstream (they're based on current git master, as of this morning, imported into our tree - you should just need to ignore our path prefix).

JK

-------------- next part --------------
A non-text attachment was scrubbed...
Name: hb-enum-trailing-commas
Type: application/octet-stream
Size: 2022 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/harfbuzz/attachments/20120116/a233f341/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hb-skip-marks-indexing
Type: application/octet-stream
Size: 10193 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/harfbuzz/attachments/20120116/a233f341/attachment-0001.obj>
-------------- next part --------------


On 15 Jan 2012, at 20:37, Behdad Esfahbod wrote:

> Hi,
> 
> This is really Jonathan's call.  I'm guessing that because Firefox has not
> rebased their HarfBuzz for a while.  A lot has changed since, so it's a bit
> more than minor effort to update.  But I'm hoping that it would happen sooner
> than later.
> 
> behdad
> 
> On 12/28/2011 09:56 AM, tugi e wrote:
>> Hallo Behdad and Jonathan,
>> 
>> Harfbuzz supports already the classic Mongolian shaping (See here:
>> https://bugs.freedesktop.org/show_bug.cgi?id=32274 ). But Firefox doesn't
>> currently support the classic Mongolian. Is there any reason for that or does
>> Firefox use still an old version of Harfbuzz? If yes, is there any plan to
>> update the Harfbuzz branch in Firefox?
>> 
>> best regards
>> tugstugi
>> 
>> 
>> 
>> _______________________________________________
>> HarfBuzz mailing list
>> HarfBuzz at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/harfbuzz
> _______________________________________________
> HarfBuzz mailing list
> HarfBuzz at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/harfbuzz