[igt-dev] [PATCH i-g-t] tests/kms_getfb: Use fixtures and subtest groups

[Arkadiusz Hiler]

On Mon, Apr 02, 2018 at 10:13:19AM -0700, Antonio Argenziano wrote:
> 
> 
> On 02/04/18 06:02, Daniel Stone wrote:
> > Hi Antonio,
> > 
> > On 30 March 2018 at 22:01, Antonio Argenziano
> > <antonio.argenziano at intel.com> wrote:
> > > Since both test_handle_input and test_duplicate_handles define some
> > > sub-tests and some fixtures, I think it would be better to unwrap those
> > > functions and do all fixtures and subtest definition in igt_main to make it
> > > more readable. It seems like you would also be able to reuse the same
> > > fixture across the two subtest_groups.
> > 
> > To be clear, does this mean that each piece of fixture and igt_subtest
> > definition should live inside main?
> 
> I don't think there is a rule for that, it looks better that way
> (fixtures/igt_subtest/subtest_group all in the main) IMO :). Also it is what
> I've found in most if not all tests I've looked at.

Definately not a rule, and definately not a patch to enforce such
preference :-P

But generally it's a good default.

> Still the patch makes sense with or without my suggestion.
> Acked-by: Antonio Argenziano <antonio.argenziano at intel.com>

Thanks, will push in a second.