[igt-dev] [PATCH i-g-t] tests/kms_getfb: Use fixtures and subtest groups

[Daniel Stone]

Hi Arkadiusz,

On 4 April 2018 at 15:00, Arkadiusz Hiler <arkadiusz.hiler at intel.com> wrote:
> On Mon, Apr 02, 2018 at 10:13:19AM -0700, Antonio Argenziano wrote:
>> On 02/04/18 06:02, Daniel Stone wrote:
>> > To be clear, does this mean that each piece of fixture and igt_subtest
>> > definition should live inside main?
>>
>> I don't think there is a rule for that, it looks better that way
>> (fixtures/igt_subtest/subtest_group all in the main) IMO :). Also it is what
>> I've found in most if not all tests I've looked at.
>
> Definately not a rule, and definately not a patch to enforce such
> preference :-P
>
> But generally it's a good default.

Thanks for pushing this. I haven't done the rework yet because I've
been busy with some more urgent fires this week; I'll rewrite
everything to be directly under main() later this week.

Cheers,
Daniel