[igt-dev] [RFT v4 4/6] igt/i915: Require GTT mapping to be available when needed.

[Chris Wilson]

Quoting Antonio Argenziano (2019-04-11 19:13:20)
> 
> 
> On 27/03/19 14:05, Antonio Argenziano wrote:
> > 
> > 
> > On 25/03/19 16:36, Chris Wilson wrote:
> >> Quoting Antonio Argenziano (2019-03-25 23:20:41)
> 
> >>> diff --git a/tests/i915/gem_render_copy.c b/tests/i915/gem_render_copy.c
> >>> index 8d62a0f4..5757c547 100644
> >>> --- a/tests/i915/gem_render_copy.c
> >>> +++ b/tests/i915/gem_render_copy.c
> >>> @@ -572,6 +572,8 @@ static void test(data_t *data, uint32_t tiling, 
> >>> uint64_t ccs_modifier)
> >>>          int opt_dump_aub = igt_aub_dump_enabled();
> >>>          int num_src = ARRAY_SIZE(src);
> >>> +       gem_require_mmap_gtt(data->drm_fd);
> >>
> >> We should make sure gem_render_copy remains available for debugging the
> >> rendercopy routines, I doubt they are going away.
> 
> We can only keep the one that doesn't do tiling AFAICT.

Detiling on the cpu is easy enough, or detile on the gpu. The latter is
a little less bullet proof (2 rendercopies to debug for the price of 1).
-Chris