[igt-dev] [PATCH i-g-t] tests/i915_pm_sseu: Don't try to get enabled subslices if it's not there

Arkadiusz Hiler arkadiusz.hiler at intel.com
Wed Jul 24 08:38:34 UTC 2019


The debugfs contains "Enabled SliceX subslices:" line only if a given
slice is enabled. If we try to dbg_get_status() with everything shut
down we will get a confusing assertion failure:

CRITICAL: Test assertion failure function dbg_get_int, file ../tests/i915/i915_pm_sseu.c:120:
CRITICAL: Failed assertion: pos != NULL

To fix that let's just read the enabled subslices if the line is there,

Cc: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110593
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
---
 tests/i915/i915_pm_sseu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/i915/i915_pm_sseu.c b/tests/i915/i915_pm_sseu.c
index 252df7d3..0b936982 100644
--- a/tests/i915/i915_pm_sseu.c
+++ b/tests/i915/i915_pm_sseu.c
@@ -199,7 +199,7 @@ dbg_get_status(struct status *stat)
 	if (dbg_has_line(first, last, "Enabled Subslice Per Slice:")) {
 		stat->hw.subslice_per =
 			dbg_get_int(first, last, "Enabled Subslice Per Slice:");
-	} else {
+	} else if (dbg_has_line(first, last, "Enabled Slice0 subslices:")) {
 		stat->hw.subslice_per =
 			dbg_get_int(first, last, "Enabled Slice0 subslices:");
 	}
-- 
2.21.0



More information about the igt-dev mailing list