[igt-dev] [PATCH i-g-t 2/2] test/i915: gem_exec_parallel: Fix for using context engine map

Chris Wilson chris at chris-wilson.co.uk
Tue Nov 19 11:36:20 UTC 2019


Quoting Tvrtko Ursulin (2019-11-19 11:22:30)
> 
> On 19/11/2019 11:11, Chris Wilson wrote:
> > Quoting Venkata Sandeep Dhanalakota (2019-11-19 11:01:17)
> >> Since engines are now looked up based on context engine map,
> >> context should be setup with engines before using in execbuf.
> > 
> > Stop changing fundamental tests of legacy behaviour. If you want to
> > exercise new API, do so in parallel.
> 
> The test is already using the new api so as it stands there's a mismatch 
> on engine flags and context - since it passes the engine flags to the 
> thread, derived from a context with engine map, but the thread uses a 
> legacy context. It has to be aligned for the intended engine to get 
> exercised.

Then consider it a retrospective complaint for mucking up a basic test :-p
-Chris


More information about the igt-dev mailing list