[igt-dev] [PATCH i-g-t 2/2] test/i915: gem_exec_parallel: Fix for using context engine map

[Venkata Sandeep Dhanalakota]

On 19/11/19 11:36, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-11-19 11:22:30)
> > 
> > On 19/11/2019 11:11, Chris Wilson wrote:
> > > Quoting Venkata Sandeep Dhanalakota (2019-11-19 11:01:17)
> > >> Since engines are now looked up based on context engine map,
> > >> context should be setup with engines before using in execbuf.
> > > 
> > > Stop changing fundamental tests of legacy behaviour. If you want to
> > > exercise new API, do so in parallel.
> > 
> > The test is already using the new api so as it stands there's a mismatch 
> > on engine flags and context - since it passes the engine flags to the 
> > thread, derived from a context with engine map, but the thread uses a 
> > legacy context. It has to be aligned for the intended engine to get 
> > exercised.
> 
> Then consider it a retrospective complaint for mucking up a basic test :-p
I've added Andy to thread(owner of orginal patch series). I'm wondering if we
should review the all tests which are adopted to use new API only and
have both legacy and new behaviour.

~Sandeep.
> -Chris