[igt-dev] [PATCH i-g-t v33 37/40] tests/gem_ppgtt: address review comments (use device mapping)

Zbigniew Kempczyński zbigniew.kempczynski at intel.com
Mon Aug 31 13:30:46 UTC 2020


Use device mapping to be consisted when exercising coherency in the tests.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
Cc: Dominik Grzegorzek <dominik.grzegorzek at intel.com>
Cc: Chris Wilson <chris at chris-wilson.co.uk>
---
 tests/i915/gem_ppgtt.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/tests/i915/gem_ppgtt.c b/tests/i915/gem_ppgtt.c
index e4b1fe45..bf412bf2 100644
--- a/tests/i915/gem_ppgtt.c
+++ b/tests/i915/gem_ppgtt.c
@@ -48,14 +48,9 @@ static struct intel_buf *create_bo(struct buf_ops *bops, uint32_t pixel)
 {
 	uint64_t value = (uint64_t)pixel << 32 | pixel, *v;
 	struct intel_buf *buf;
-	int i915 = buf_ops_get_fd(bops);
 
 	buf = intel_buf_create(bops, WIDTH, HEIGHT, 32, 0, I915_TILING_NONE, 0);
-
-	if (gem_has_llc(i915))
-		v = intel_buf_cpu_map(buf, true);
-	else
-		v = intel_buf_device_map(buf, true);
+	v = intel_buf_device_map(buf, true);
 
 	for (int i = 0; i < SIZE / sizeof(value); i += 8) {
 		v[i + 0] = value; v[i + 1] = value;
-- 
2.26.0



More information about the igt-dev mailing list