[igt-dev] [PATCH i-g-t v33 38/40] tests/gem_concurrent_all: address review comment (remove sync)

Zbigniew Kempczyński zbigniew.kempczynski at intel.com
Mon Aug 31 13:30:47 UTC 2020


Random sync lead to not concurrent execution what is not we want.
Fix that.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
Cc: Dominik Grzegorzek <dominik.grzegorzek at intel.com>
Cc: Chris Wilson <chris at chris-wilson.co.uk>
---
 tests/i915/gem_concurrent_all.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/tests/i915/gem_concurrent_all.c b/tests/i915/gem_concurrent_all.c
index 90e132ff..48b0315d 100644
--- a/tests/i915/gem_concurrent_all.c
+++ b/tests/i915/gem_concurrent_all.c
@@ -633,13 +633,9 @@ static void
 cpu_set_bo(struct buffers *b, struct intel_buf *buf, uint32_t val)
 {
 	int size = b->npixels;
-	int i915 = buf_ops_get_fd(buf->bops);
 	uint32_t *vaddr;
 
-	if (gem_has_llc(i915))
-		intel_buf_cpu_map(buf, true);
-	else
-		intel_buf_device_map(buf, true);
+	intel_buf_device_map(buf, true);
 
 	vaddr = buf->ptr;
 	while (size--)
@@ -876,7 +872,6 @@ static void render_copy_bo(struct buffers *b, struct intel_buf *dst,
 		   src, 0, 0,
 		   b->width, b->height,
 		   dst, 0, 0);
-	intel_bb_sync(b->ibb);
 	intel_bb_reset(b->ibb, true);
 }
 
@@ -887,7 +882,6 @@ static void blt_copy_bo(struct buffers *b, struct intel_buf *dst,
 		       src, 0, 0, 4*b->width,
 		       dst, 0, 0, 4*b->width,
 		       b->width, b->height, 32);
-	intel_bb_sync(b->ibb);
 	intel_bb_reset(b->ibb, true);
 }
 
-- 
2.26.0



More information about the igt-dev mailing list