[igt-dev] [PATCH v2 0/4] Make kms_concurrent, transition, and atomic generic

Choi, Nicholas Nicholas.Choi at amd.com
Fri Aug 27 17:46:51 UTC 2021


[AMD Official Use Only]

This series looks good to me, and I tested it on our internal CI with our hardware.

Series is:
Reviewed-By: Nicholas Choi <Nicholas.Choi at amd.com>

Thanks.
________________________________
From: Siqueira, Rodrigo <Rodrigo.Siqueira at amd.com>
Sent: Wednesday, August 25, 2021 10:36 AM
To: igt-dev at lists.freedesktop.org <igt-dev at lists.freedesktop.org>
Cc: abhinavk at codeaurora.org <abhinavk at codeaurora.org>; Wentland, Harry <Harry.Wentland at amd.com>; Choi, Nicholas <Nicholas.Choi at amd.com>; Sean Paul <seanpaul at chromium.org>; Mark Yacoub <markyacoub at chromium.org>; Melissa Wen <melissa.srw at gmail.com>; Arkadiusz Hiler <arek at hiler.eu>; Petri Latvala <petri.latvala at intel.com>
Subject: [PATCH v2 0/4] Make kms_concurrent, transition, and atomic generic

This series target three KMS tests:

1. kms_concurrent
2. kms_transition
3. kms_atomic

All of these tests fail in the amdgpu or the VKMS drivers. After
debugging the issue, I realize that we need to make these tests generic
for other drivers, and we also need minor fixes to enable it for
different devices. Mark submitted the first patch of this series a long
time ago; I just update the commit message and rebase it in the latest
code. The patch associate with kms_concurrent makes it generic enough to
run in VKMS and VC4. Finally, for the kms_atomic I added a bug fix, and
I also skip one test that does not apply to amdgpu.

Change since V1:
- Use DRM_FORMAT_MOD_LINEAR instead of DRM_FORMAT_MOD_NONE
- Improve skip message
- Rebase
- Test on VC4

Thanks
Siqueira

Cc: Harry Wentland <harry.wentland at amd.com>
Cc: Nicholas Choi <Nicholas.Choi at amd.com>
Cc: Sean Paul <seanpaul at chromium.org>
Cc: Mark Yacoub <markyacoub at chromium.org>
Cc: Melissa Wen <melissa.srw at gmail.com>
Cc: Arkadiusz Hiler <arek at hiler.eu>
Cc: Petri Latvala <petri.latvala at intel.com>

Mark Yacoub (1):
  tests/kms_atomic_transition: Enable Primary Plane on Enabling CRTC

Rodrigo Siqueira (3):
  tests/kms_concurrent: Making the test more generic
  tests/kms_atomic: Initialize array values before checking them
  test/kms_atomic: Skip plane overlay test for amdgpu

 tests/kms_atomic.c            |  9 +++++++++
 tests/kms_atomic_transition.c |  6 +++---
 tests/kms_concurrent.c        | 27 ++++++++++++++-------------
 3 files changed, 26 insertions(+), 16 deletions(-)

--
2.25.1

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/igt-dev/attachments/20210827/070449ec/attachment.htm>


More information about the igt-dev mailing list