[igt-dev] [PATCH] tests/kms_prime: Filter out devices that can't import buffers.

Christian König christian.koenig at amd.com
Wed Jun 16 08:07:18 UTC 2021



Am 16.06.21 um 09:34 schrieb Petri Latvala:
> On Tue, Jun 15, 2021 at 06:20:23PM +0200, Christian König wrote:
>> The alternative would be to try to create a framebuffer, but don't take it
>> as a failure when that fails with the correct return code.
> This.
>
> If the importing can fail for documented reasons, we should just add
> code that checks that the error is the documented one and then
> igt_skip(), fail the test if it's something it shouldn't.

Good point, but I don't think that this behavior is well documented 
anywhere.

I'm also pretty sure that most drivers don't correctly reject an 
imported DMA-buf for scanout when the hardware can't do this. Resulting 
in either just garbage on the screen or a lockup.

Exercising this in an unit tests is probably a good idea, but only after 
auditing all drivers for correct behavior.

Regards,
Christian.

> As a general rule the tests goes to hardware specific subdirs if the
> interface tested is hardware-specific. This interface is not, just the
> behaviour.



More information about the igt-dev mailing list