[igt-dev] [PATCH] tests/kms_prime: Filter out devices that can't import buffers.

Petri Latvala petri.latvala at intel.com
Wed Jun 16 08:46:09 UTC 2021


On Wed, Jun 16, 2021 at 10:07:18AM +0200, Christian König wrote:
> 
> 
> Am 16.06.21 um 09:34 schrieb Petri Latvala:
> > On Tue, Jun 15, 2021 at 06:20:23PM +0200, Christian König wrote:
> > > The alternative would be to try to create a framebuffer, but don't take it
> > > as a failure when that fails with the correct return code.
> > This.
> > 
> > If the importing can fail for documented reasons, we should just add
> > code that checks that the error is the documented one and then
> > igt_skip(), fail the test if it's something it shouldn't.
> 
> Good point, but I don't think that this behavior is well documented
> anywhere.
> 
> I'm also pretty sure that most drivers don't correctly reject an imported
> DMA-buf for scanout when the hardware can't do this. Resulting in either
> just garbage on the screen or a lockup.
> 
> Exercising this in an unit tests is probably a good idea, but only after
> auditing all drivers for correct behavior.

The thing is, having a test for it is the best method of auditing and
being _sure_.

Being able to lockup devices with an operation that doesn't even
require root (?) sounds... slightly bad.


-- 
Petri Latvala


More information about the igt-dev mailing list