[igt-dev] [PATCH i-g-t] tests/i915/gem_lmem_swapping: Fix bug in test_smem_oom

Matthew Auld matthew.william.auld at gmail.com
Fri Apr 1 09:10:40 UTC 2022


 On Fri, 1 Apr 2022 at 08:28, Arjun Melkaveri <arjun.melkaveri at intel.com> wrote:
>
> ctx was not initialized with all physical engines,
> after device reopening.
> This change would resolve assert issue seen in __do_evict.
>
> v2: Added missing intel_ctx_destroy.
>

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5528 ?

> Cc: Ashutosh Dixit <ashutosh.dixit at intel.com>
> Cc: Ramalingam C <ramalingam.c at intel.com>
> Signed-off-by: Arjun Melkaveri <arjun.melkaveri at intel.com>

Sorry for breaking this,
Reviewed-by: Matthew Auld <matthew.auld at intel.com>

> ---
>  tests/i915/gem_lmem_swapping.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/tests/i915/gem_lmem_swapping.c b/tests/i915/gem_lmem_swapping.c
> index 43f0688f..432607b0 100644
> --- a/tests/i915/gem_lmem_swapping.c
> +++ b/tests/i915/gem_lmem_swapping.c
> @@ -428,10 +428,14 @@ static void test_smem_oom(int i915,
>
>                 fill_params(i915, &params, region, 0, 1, true);
>
> +               ctx = intel_ctx_create_all_physical(fd);
> +               __gem_context_set_persistence(fd, ctx->id, false);
> +
>                 igt_install_exit_handler(smem_oom_exit_handler);
>                 __do_evict(fd, ctx, &region->region, &params,
>                            params.seed + child + 1);
>
> +               intel_ctx_destroy(fd, ctx);
>                 close(fd);
>         }
>
> --
> 2.25.1
>


More information about the igt-dev mailing list