[igt-dev] [PATCH i-g-t] Add dynamic subtests

[Modem, Bhanuprakash]

On Thu-31-03-2022 11:54 am, Nidhi Gupta wrote:
> Modified kms_sequence and kms_concurrent to include
> dynamic subtests.
> 
> Signed-off-by: Nidhi Gupta <nidhi1.gupta at intel.com>
> ---
>   tests/kms_concurrent.c | 6 ++++--
>   tests/kms_sequence.c   | 6 ++++--
>   2 files changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
> index dc1e36f2..5536a369 100644
> --- a/tests/kms_concurrent.c
> +++ b/tests/kms_concurrent.c
> @@ -339,9 +339,11 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)
>   
>   	igt_describe("Test atomic mode setting concurrently with multiple planes and screen "
>   		     "resolution.");
> -	igt_subtest_f("pipe-%s", kmstest_pipe_name(pipe))
> +	igt_subtest_with_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) {
>   		for_each_valid_output_on_pipe(&data->display, pipe, output)
> -			run_test(data, pipe, output);
> +			igt_dynamic_f("%s", igt_output_name(output))
> +				run_test(data, pipe, output);
> +	}
>   }
>   
>   static int opt_handler(int option, int option_index, void *input)
> diff --git a/tests/kms_sequence.c b/tests/kms_sequence.c
> index 9c287480..d33669a7 100644
> --- a/tests/kms_sequence.c
> +++ b/tests/kms_sequence.c
> @@ -278,6 +278,7 @@ igt_main
>   		fd = drm_open_driver_master(DRIVER_ANY);
>   		kmstest_set_vt_graphics_mode();
>   		igt_display_require(&data.display, fd);
> +		igt_display_require_output(&data.display);
>   	}
>   
>   	for (f = funcs; f->name; f++) {
> @@ -287,9 +288,10 @@ igt_main
>   
>   			igt_describe("This is a test of drmCrtcGetSequence and "
>   				     "drmCrtcQueueSequence");
> -			igt_subtest_f("%s-%s", f->name, m->name) {
> +			igt_subtest_with_dynamic_f("%s-%s", f->name, m->name) {
>   				data.flags = m->flags;
> -				run_test(&data, fd, f->func);
> +				igt_dynamic_f("%s", igt_output_name(data.output))

This is wrong, data.output is not initialized.

- Bhanu
> +					run_test(&data, fd, f->func);
>   			}
>   		}
>   	}