[igt-dev] [PATCH i-g-t] tests/i915/kms_big_fb: take out test only flag for try commit in inner loop
Juha-Pekka Heikkila
juhapekka.heikkila at gmail.com
Wed Apr 6 13:00:58 UTC 2022
This will cause try commit to do modeset which could cause crc buffer
overflow in later commit. I changed small fb not to be cleared with
green color so there will be no unnecessary green flashes, this seem
to also take portion of execution time away.
Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
---
tests/i915/kms_big_fb.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/tests/i915/kms_big_fb.c b/tests/i915/kms_big_fb.c
index 8724d6069..7c9bb5d2a 100644
--- a/tests/i915/kms_big_fb.c
+++ b/tests/i915/kms_big_fb.c
@@ -348,8 +348,7 @@ static bool test_plane(data_t *data)
*/
if (i == 0 && data->display.is_atomic &&
igt_display_try_commit_atomic(&data->display,
- DRM_MODE_ATOMIC_ALLOW_MODESET |
- DRM_MODE_ATOMIC_TEST_ONLY,
+ DRM_MODE_ATOMIC_ALLOW_MODESET,
NULL) != 0) {
if (igt_plane_has_prop(plane, IGT_PLANE_ROTATION))
igt_plane_set_rotation(plane, IGT_ROTATION_0);
@@ -420,9 +419,8 @@ static bool test_pipe(data_t *data)
if (igt_rotation_90_or_270(data->rotation))
igt_swap(width, height);
- igt_create_color_fb(data->drm_fd, width, height,
- data->format, data->modifier,
- 0, 1, 0, &data->small_fb);
+ igt_create_fb(data->drm_fd, width, height,
+ data->format, data->modifier, &data->small_fb);
igt_output_set_pipe(data->output, data->pipe);
--
2.28.0
More information about the igt-dev
mailing list