[igt-dev] [PATCH 0/2] Introduce MAINTAINERS file to IGT

[Vivi, Rodrigo]

On Wed, 2022-03-16 at 09:24 -0400, Rodrigo Siqueira Jordao wrote:


On 2022-03-01 14:55, Rodrigo Vivi wrote:
On Thu, Feb 17, 2022 at 10:26:44AM -0500, Rodrigo Siqueira wrote:
IGT is becoming more generic, and multiple vendors are adopting it. For
example, AMD fully upstream all of its internal changes last year, and
now we are relying on IGT from the upstream. Additionally, thanks to the
ChromeOS project, we have other vendors working on the KMS tests as
well. At this point, I believe that we need some mechanism to better
contact developers that care about some specific tests or even provide
an easy way for other people to find the right stakeholder for dealing
with some particular issue.

Imho Linux Kernel already has a good solution codified in the
MAINTAINERS and get_maintainers files. One of the best things about this
approach was adding reviewers and maintainers (and other options) to the
specific part of the code and using the get_maintainers tool to extract
the right people to be part of the series. With this idea in mind, I
created an RFC that introduces the MAINTAINERS file in IGT, and
collected feedback. This series is the first version that introduces the
MAINTAINERS and a wrapper to the get_maintainers file.

But in the Linux Kernel we do for big blocks, not for individual .c files.
For the .c files git blame should be enough imho...

Hi Rodrigo,

I don't think git blame will work for what I'm suggesting. What I'm
trying to achieve here is a bit different; I'm trying to add more
contact points for specific tests since IGT became more and more adopted.
For example, last year, we retired our IGT fork and tried to upstream
all of our internal changes since we want to move to the upstream first
approach with IGT. As a result of this change, our CI now relies on IGT
from GitLab, and we run a lot of the kms tests, but we did not directly
work in some of them. In those cases, git blame will not point to anyone
from AMD. If you see the first patch, we are trying to add specific
people to follow certain tests to make the IGT maintenance scalable for
us and for anyone using IGT in their CI.

I totally understand your goal here and I fully support any action that brings the
upstream first approach. My biggest concern with this approach is the maintenance cost.
A list big and very specific like this will likely change quickly and get outdated in the blink of an eye.

But it is just my personal thought on this. Please sync with Petri to determine the good path of this.


Thanks
Siqueira



For this series, I recommend:

1. Patch 1: It has the maintainers file. If you want to add yourself to
some specific test, please, let me know in this patch.
2. Patch 2: get_maintainers wrapper, see the CONTRIBUTING page on how to
use it.

Cc: Arkadiusz Hiler <arek at hiler.eu<mailto:arek at hiler.eu>>
Cc: Petri Latvala <petri.latvala at intel.com<mailto:petri.latvala at intel.com>>
Cc: Mark Yacoub <markyacoub at google.com<mailto:markyacoub at google.com>>
Cc: Jessica Zhang <quic_jesszhan at quicinc.com<mailto:quic_jesszhan at quicinc.com>>
Cc: Abhinav Kumar <quic_abhinavk at quicinc.com<mailto:quic_abhinavk at quicinc.com>>
Cc: Melissa Wen <mwen at igalia.com<mailto:mwen at igalia.com>>
Cc: Sean Paul <seanpaul at chromium.org<mailto:seanpaul at chromium.org>>
Cc: Harry Wentland <harry.wentland at amd.com<mailto:harry.wentland at amd.com>>
Cc: Sun Peng Li(Leo) <sunpeng.li at amd.com<mailto:sunpeng.li at amd.com>>
Cc: Chao-kai Wang (Stylon) <stylon.wang at amd.com<mailto:stylon.wang at amd.com>>
Cc: Wayne Lin <wayne.lin at amd.com<mailto:wayne.lin at amd.com>>
Cc: Nicholas Choi <nicholas.choi at amd.com<mailto:nicholas.choi at amd.com>>
Cc: Martin Peres <martin.peres at mupuf.org<mailto:martin.peres at mupuf.org>>
Cc: Aurabindo Pillai <aurabindo.pillai at amd.com<mailto:aurabindo.pillai at amd.com>>
Cc: Bhawanpreet Lakha <bhawanpreet.lakha at amd.com<mailto:bhawanpreet.lakha at amd.com>>
Cc: Qingqing Zhuo (Lilian) <qingqing.zhuo at amd.com<mailto:qingqing.zhuo at amd.com>>
Cc: Solomon Chiu <solomon.chiu at amd.com<mailto:solomon.chiu at amd.com>>
Cc: Nicholas Kazlauskas <nicholas.kazlauskas at amd.com<mailto:nicholas.kazlauskas at amd.com>>
Cc: Dingchen Zhang (David) <Dingchen.Zhang at amd.com<mailto:Dingchen.Zhang at amd.com>>

Rodrigo Siqueira (2):
   MAINTAINERS: Introduce MAINTAINERS file
   scripts: get_maintainer: Introduce get_maintainer wrapper

  .gitignore                |   1 +
  CONTRIBUTING.md           |  17 +++-
  MAINTAINERS               | 198 +++++++++++++++++++++++++++++++++++++-
  scripts/get_maintainer.sh | 104 ++++++++++++++++++++
  4 files changed, 317 insertions(+), 3 deletions(-)
  create mode 100755 scripts/get_maintainer.sh

--
2.25.1



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/igt-dev/attachments/20220321/0c09c914/attachment-0001.htm>