[igt-dev] [PATCH i-g-t v3] tests/i915/kms_draw_crc: Ignore RGB565 & XRGB2101010 formats on simulation

Nidhi Gupta nidhi1.gupta at intel.com
Wed Feb 8 07:12:45 UTC 2023


From: Bhanuprakash Modem <bhanuprakash.modem at intel.com>

As RGB565 and XRGB2101010 formats are bit slow in pre-si, we can
ignore both the formats only on simulation to improve the execution
time.
Moved the check weather display support specific format-modifier
combination before starting dynamic tests, since to
avoid skip in igt_dynamic().

v2: update the skip format condition to
    (formats[format_idx] != DRM_FORMAT_XRGB8888)
    (Juha-Pekka)

v3: update commit message (Bhanu)

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
Signed-off-by: Nidhi Gupta <nidhi1.gupta at intel.com>
---
 tests/i915/kms_draw_crc.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c
index c2ac4721..64d3b937 100644
--- a/tests/i915/kms_draw_crc.c
+++ b/tests/i915/kms_draw_crc.c
@@ -290,10 +290,18 @@ igt_main
 		     "with different modifiers, DRM_FORMATS, DRAW_METHODS.");
 	igt_subtest_with_dynamic("draw-method") {
 		for (format_idx = 0; format_idx < ARRAY_SIZE(formats); format_idx++) {
+			/* 10-bit & 16-bit formats are bit slow, ignore in pre-si. */
+			if (igt_run_in_simulation() &&
+			    formats[format_idx] != DRM_FORMAT_XRGB8888)
+				continue;
+
 			for (method = 0; method < IGT_DRAW_METHOD_COUNT; method++) {
 				for (modifier_idx = 0; modifier_idx < ARRAY_SIZE(modifiers); modifier_idx++) {
 					modifier = modifiers[modifier_idx];
 
+					if (!igt_display_has_format_mod(&display, formats[format_idx], modifier))
+						continue;
+
 					if (method == IGT_DRAW_MMAP_WC && !gem_mmap__has_wc(drm_fd))
 						continue;
 
@@ -301,9 +309,6 @@ igt_main
 					    !gem_has_mappable_ggtt(drm_fd))
 						continue;
 
-					if (!igt_display_has_format_mod(&display, formats[format_idx], modifier))
-						continue;
-
 					igt_dynamic_f("%s-%s-%s",
 						      format_str(format_idx),
 						      igt_draw_get_method_name(method),
-- 
2.39.0



More information about the igt-dev mailing list