[igt-dev] [PATCH] tests/i915/pxp: test_pxp_stale_buf_optout_execution requires arb session

Teres Alexis, Alan Previn alan.previn.teres.alexis at intel.com
Tue Feb 14 16:45:15 UTC 2023


On Mon, 2023-02-13 at 15:30 -0800, Ceraolo Spurio, Daniele wrote:
> 
> On 2/7/2023 10:24 PM, Alan Previn wrote:
> > Subtest 'test_pxp_stale_buf_optout_execution' when run on its own,
> > could be executing without the PXP Arb session being alive. This
> > would result in the termination trigger to fail (when writing to
> > the pxp termination debugfs).
> > 
> > Create a background protected context to start the Arb session so
> > the simulated termination will succeed.
> > 
> > Signed-off-by: Alan Previn <alan.previn.teres.alexis at intel.com>
> > +	prepare_exec_assets(i915, &data2, true, true);
> 
alan:snip

> Since you only need the context, wouldn't a call to 
> create_ctx_with_params be more appropriate here? that way we don't have 
> to allocate all the extra stuff.
> 
> Daniele
> 
good point - yes we can use that - will re-rev.



More information about the igt-dev mailing list