[igt-dev] [PATCH i-g-t 3/3] igt: Switch warning to an info when not using i915
Kamil Konieczny
kamil.konieczny at linux.intel.com
Fri Feb 17 17:35:59 UTC 2023
Hi Zack,
I merged this patch, no need for resend.
btw note new Petri address, Petri Latvala <adrinael at adrinael.net>
Regards,
Kamil
On 2023-01-26 at 19:11:18 +0000, Zack Rusin wrote:
> On Thu, 2023-01-26 at 19:17 +0100, Kamil Konieczny wrote:
> > !! External Email
> >
> > Hi Zack,
> >
> > On 2022-11-29 at 12:27:18 -0500, Zack Rusin wrote:
> > > From: Zack Rusin <zackr at vmware.com>
> > >
> > > Because igt always tries to load i915 driver first for DRIVER_ANY every
> > > test using DRIVER_ANY on anything but i915 starts by printing a warning
> > > that i915 couldn't be loaded.
> > > Lets switch it to a general info line because it makes it hard to spot
> > > actual warnings when every subtest starts by warning about not being
> > > able to load i915.
> > >
> > > Signed-off-by: Zack Rusin <zackr at vmware.com>
> > > ---
> > > lib/igt_kmod.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
> > > index bcf7dfeb..74924b5f 100644
> > > --- a/lib/igt_kmod.c
> > > +++ b/lib/igt_kmod.c
> > > @@ -389,7 +389,7 @@ igt_i915_driver_load(const char *opts)
> >
> > This is i915 driver load so maybe we should find a way to not
> > call this function ?
>
> That'd be fine, how would you do that? IGT has a number of tests (the core ones)
> that use DRIVER_ANY for load the first available driver. Unless we explicitly
> exclude i915 from running those tests, or reorder the enum to try i915 after all the
> other options then it's not a trivial fix. We'd need to do add proper pci device id
> matching to always use the correct driver, which would be great, but is probably a
> little out of scope for this change.
>
> z
>
More information about the igt-dev
mailing list