[igt-dev] [PATCH i-g-t 1/3] igt/vmwgfx: Add support for testing vmwgfx

Kamil Konieczny kamil.konieczny at linux.intel.com
Fri Feb 17 17:50:54 UTC 2023


Hi Zack,

On 2023-01-26 at 19:06:49 +0000, Zack Rusin wrote:
> On Thu, 2023-01-26 at 19:13 +0100, Kamil Konieczny wrote:
> > !! External Email
> > 
> > Hi,
> > 
> > please rebase and resend. Please also shorten licence,
> > we use SPDX to not write out big text (see one example below).
> > You can also use checkpatch script from Linux kernel, it will
> > provide some hints for improvement.
> > 
> > Please also find someone from vmware for review of vmware
> > specific parts of your tests and libs.
> 
> I did that. This was written by Maaz and Roy and reviewed by me. I know that some
> projects use signed-off differently, usually it implies review, but I'm happy to
> provide both reviewed-by and signed-off if that's what you prefer.
> 
> z

Please rebase, drop 3/3 patch (it was already merged) and resend.
Also address comments about your patches. Btw if the patches were
developed by Maaz and Roy, then there should be signed-off-by
from Maaz but there are only s-o-b from Roye and you.

Please consider splitting this patchseries into smaller portions
like very basic functionality first, then adding step by step
more into libs and tests.

After you will address all comments and patches will be ready
for merge you may add then your r-b tag.

+cc Petri

Regards,
Kamil



More information about the igt-dev mailing list