[igt-dev] [PATCH i-g-t 0/3] runner: Using 'abort' as test result instead of a separate test

Petri Latvala petri.latvala at intel.com
Thu Jan 26 10:53:35 UTC 2023


If a test caused an abort condition to trigger, a pseudoresult
"igt at runner@aborted" would be generated, detailing which test caused
the condition. That was implemented in a simpler world where there
were no dynamic subtests and CI systems (i915-CI in particular) didn't
have much test resuming happening.

The generated pseudoresult was completely unable to point to a
particular dynamic subtest if the executed subtest had any, and there
could inherently be only one of them. When combined with the fact that
the pseudoresult doesn't have logs that could be used to automatically
point to particular bug reports, that made results filtering by
CIBugLog difficult.

With socket communications it's easier to inject information "in
between" test's logs and result overriding is designed into the
system. Thus, when using socket communications, this patch series will
make the abort-condition-causing test's result 'abort' instead of
using that pseudoresult.

The flow becomes a little bit messier with monitor_output() gaining
more and more out-parameters but those can be cleaned later.

Petri Latvala (3):
  runner: Don't override more results than requested
  runner: Refactor abort-checking to a helper function
  runner: Use 'abort' as result if a test caused an abort

 runner/executor.c  | 121 +++++++++++++++++++++++++++++++++++++++------
 runner/resultgen.c |   6 +++
 2 files changed, 111 insertions(+), 16 deletions(-)

-- 
2.30.2



More information about the igt-dev mailing list