[igt-dev] [PATCH i-g-t 1/3] runner: Don't override more results than requested

Petri Latvala petri.latvala at intel.com
Thu Jan 26 10:53:36 UTC 2023


When processing a resultoverride packet, the override is supposed to
apply only to the most recent subtest or dynamic subtest. Properly
clear the override so only those results get overridden.

Signed-off-by: Petri Latvala <petri.latvala at intel.com>
Cc: Arkadiusz Hiler <arek at hiler.eu>
Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
---
 runner/resultgen.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/runner/resultgen.c b/runner/resultgen.c
index 596de786..b00bb6ba 100644
--- a/runner/resultgen.c
+++ b/runner/resultgen.c
@@ -1540,6 +1540,9 @@ static bool comms_handle_subtest_start(const struct runnerpacket *packet,
 		/* Subtest starting message is not in logs with socket comms, inject it manually */
 		comms_inject_subtest_start_log(context, STARTING_SUBTEST, helper.subteststart.name);
 
+		free(context->subtestresult);
+		context->subtestresult = NULL;
+
 		break;
 	default:
 		assert(false); /* unreachable */
@@ -1669,6 +1672,9 @@ static bool comms_handle_dynamic_subtest_start(const struct runnerpacket *packet
 		/* Dynamic subtest starting message is not in logs with socket comms, inject it manually */
 		comms_inject_subtest_start_log(context, STARTING_DYNAMIC_SUBTEST, helper.dynamicsubteststart.name);
 
+		free(context->dynamicsubtestresult);
+		context->dynamicsubtestresult = NULL;
+
 		break;
 	default:
 		assert(false); /* unreachable */
-- 
2.30.2



More information about the igt-dev mailing list