[igt-dev] [PATCH 2/3] igt_kms: add hotspot plane property

[Javier Martinez Canillas]

Hello Albert,

Patch looks good to me. But I'm not really familiar with the IGT codebase.

Acked-by: Javier Martinez Canillas <javierm at redhat.com>

I've one question below though:

Albert Esteve <aesteve at redhat.com> writes:

[...]

> @@ -2679,6 +2686,8 @@ void igt_display_require(igt_display_t *display, int drm_fd)
>  	drmSetClientCap(drm_fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
>  	if (drmSetClientCap(drm_fd, DRM_CLIENT_CAP_ATOMIC, 1) == 0)
>  		display->is_atomic = 1;
> +	
> +	drmSetClientCap(drm_fd, DRM_CLIENT_CAP_CURSOR_PLANE_HOTSPOT, 1);
>

Should this capability be set unconditionally? 

Do we want to also test the case when user-space doesn't opt-in and does
not know how to handle the hostpost properties ?

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat