[igt-dev] [PATCH 2/3] igt_kms: add hotspot plane property

[Albert Esteve]

On Tue, Jul 25, 2023 at 3:40 PM Javier Martinez Canillas <javierm at redhat.com>
wrote:

>
> Hello Albert,
>
> Patch looks good to me. But I'm not really familiar with the IGT codebase.
>
> Acked-by: Javier Martinez Canillas <javierm at redhat.com>
>
> I've one question below though:
>
> Albert Esteve <aesteve at redhat.com> writes:
>
> [...]
>
> > @@ -2679,6 +2686,8 @@ void igt_display_require(igt_display_t *display,
> int drm_fd)
> >       drmSetClientCap(drm_fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
> >       if (drmSetClientCap(drm_fd, DRM_CLIENT_CAP_ATOMIC, 1) == 0)
> >               display->is_atomic = 1;
> > +
> > +     drmSetClientCap(drm_fd, DRM_CLIENT_CAP_CURSOR_PLANE_HOTSPOT, 1);
> >
>
> Should this capability be set unconditionally?
>
>
Probably could be set similarly to how the atomic capability is set, track
the property in the display
structure, and run the hotspot test only in cases where client understands
hotspot properties.
I can change this in the next drop.


> Do we want to also test the case when user-space doesn't opt-in and does
> not know how to handle the hostpost properties ?
>

In those cases, if setting the capability fails, it is probably better to
just skip the test.


>
> --
> Best regards,
>
> Javier Martinez Canillas
> Core Platforms
> Red Hat
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/igt-dev/attachments/20230726/e0d8f98f/attachment.htm>