[igt-dev] [PATCH 1/2] [PATCH i-g-t] tests/i915: Increase timeout for GuC submission

Kamil Konieczny kamil.konieczny at linux.intel.com
Wed Mar 29 09:40:54 UTC 2023


On 2023-03-29 at 10:58:47 +0530, pallavi.mishra at intel.com wrote:
> From: Pallavi Mishra <pallavi.mishra at intel.com>
> 
> Increase reset timeout as resets can take a bit longer with GuC
> submission because an error capture is done and with a large GuC log
> (16MB) these take a while.
> 
> Co-authored-by: Matthew Brost <matthew.brost at intel.com>
> Signed-off-by: Pallavi Mishra <pallavi.mishra at intel.com>

LGTM,
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> ---
>  tests/i915/sysfs_heartbeat_interval.c | 2 +-
>  tests/i915/sysfs_timeslice_duration.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/i915/sysfs_heartbeat_interval.c b/tests/i915/sysfs_heartbeat_interval.c
> index 8cebf627..8a3dd397 100644
> --- a/tests/i915/sysfs_heartbeat_interval.c
> +++ b/tests/i915/sysfs_heartbeat_interval.c
> @@ -43,7 +43,7 @@
>  #include "sw_sync.h"
>  
>  #define ATTR "heartbeat_interval_ms"
> -#define RESET_TIMEOUT 50 /* milliseconds, at least one jiffie for kworker */
> +#define RESET_TIMEOUT 1000 /* milliseconds, long enough for error capture */
>  
>  static bool __enable_hangcheck(int dir, bool state)
>  {
> diff --git a/tests/i915/sysfs_timeslice_duration.c b/tests/i915/sysfs_timeslice_duration.c
> index 80d34285..c23424c6 100644
> --- a/tests/i915/sysfs_timeslice_duration.c
> +++ b/tests/i915/sysfs_timeslice_duration.c
> @@ -44,7 +44,7 @@
>  #include "sw_sync.h"
>  
>  #define ATTR "timeslice_duration_ms"
> -#define RESET_TIMEOUT 50 /* milliseconds, at least one jiffie for kworker */
> +#define RESET_TIMEOUT 1000 /* milliseconds, long enough for error capture */
>  
>  static bool __enable_hangcheck(int dir, bool state)
>  {
> -- 
> 2.25.1
> 


More information about the igt-dev mailing list