[igt-dev] [PATCH 2/2] [PATCH i-g-t] i915/sysfs_timeslice_duration: skip off subtest for GuC submission

[Kamil Konieczny]

On 2023-03-29 at 10:58:48 +0530, pallavi.mishra at intel.com wrote:
> From: Pallavi Mishra <pallavi.mishra at intel.com>
> 
> Don't run 'off' section as with GuC submission we don't handle
> dynamically changing the timeslice duration from 'off' to 'on' on a
> currently running context. This is not bug in GuC submission rather an
> architectural decision to not implement this as there is no user aside
> from IGTs.
> 
> Co-authored-by: Matthew Brost <matthew.brost at intel.com>
> Signed-off-by: Pallavi Mishra <pallavi.mishra at intel.com>

LGTM,
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

btw if you may please use my @linux address above for patches.

--
Kamil
> ---
>  tests/i915/sysfs_timeslice_duration.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/tests/i915/sysfs_timeslice_duration.c b/tests/i915/sysfs_timeslice_duration.c
> index c23424c6..92c4c5ea 100644
> --- a/tests/i915/sysfs_timeslice_duration.c
> +++ b/tests/i915/sysfs_timeslice_duration.c
> @@ -29,6 +29,7 @@
>  #include <sys/types.h>
>  #include <unistd.h>
>  
> +#include "igt.h"
>  #include "igt_params.h"
>  #include "drmtest.h"
>  #include "i915/gem.h"
> @@ -475,6 +476,13 @@ static void test_off(int i915, int engine)
>  	gem_quiescent_gpu(i915);
>  	igt_require(enable_hangcheck(i915, false));
>  
> +	/* GuC does not handle dynamic change in timeslice
> +	 * duration from 'off' to 'on' on a currently
> +	 * running context. Hence add below check.
> +	 */
> +
> +	igt_require(!gem_using_guc_submission(i915));
> +
>  	igt_assert(igt_sysfs_scanf(engine, "class", "%u", &class) == 1);
>  	igt_assert(igt_sysfs_scanf(engine, "instance", "%u", &inst) == 1);
>  
> -- 
> 2.25.1
>