[i-g-t 1/4] tests/kms_color: Add more logs to skips

[Samala, Pranay]

> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of
> Bhanuprakash Modem
> Sent: Tuesday, August 13, 2024 11:09 AM
> To: igt-dev at lists.freedesktop.org
> Cc: Modem, Bhanuprakash <bhanuprakash.modem at intel.com>
> Subject: [i-g-t 1/4] tests/kms_color: Add more logs to skips
> 
> Debugging would be easier if we had logs available for test failures and skips. This
> patch adds print statements at crucial points to provide better insights.

This patch LGTM.

Reviewed-by: Pranay Samala <pranay.samala at intel.com> 
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
> ---
>  tests/kms_color.c | 21 +++++++++++++++++----
>  1 file changed, 17 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/kms_color.c b/tests/kms_color.c index 645a03537..5f0128bca
> 100644
> --- a/tests/kms_color.c
> +++ b/tests/kms_color.c
> @@ -893,11 +893,18 @@ run_deep_color_tests_for_pipe(data_t *data, enum
> pipe p)
>  		uint64_t max_bpc = get_max_bpc(output);
>  		bool ret;
> 
> -		if (!max_bpc)
> +		if (!max_bpc) {
> +			igt_info("Output %s: Doesn't support \"max bpc\"
> property.\n",
> +				 igt_output_name(output));
>  			continue;
> +		}
> 
> -		if (!panel_supports_deep_color(data->drm_fd, output->name))
> +		if (!panel_supports_deep_color(data->drm_fd, output->name)) {
> +			igt_info("Output %s: Doesn't support deep-color.\n",
> +				 igt_output_name(output));
>  			continue;
> +		}
> +
>  		/*
>  		 * In intel driver, for MST streams pipe_bpp is
>  		 * restricted to 8bpc. So, deep-color >= 10bpc @@ -905,16
> +912,22 @@ run_deep_color_tests_for_pipe(data_t *data, enum pipe p)
>  		 * supports 10bpc. Once KMD FIXME, is resolved
>  		 * this MST constraint can be removed.
>  		 */
> -		if (is_intel_device(data->drm_fd) &&
> igt_check_output_is_dp_mst(output))
> +		if (is_intel_device(data->drm_fd) &&
> igt_check_output_is_dp_mst(output)) {
> +			igt_info("Output %s: DP-MST doesn't support deep-color
> on Intel hardware.\n",
> +				 igt_output_name(output));
>  			continue;
> +		}
> 
>  		igt_display_reset(&data->display);
>  		igt_output_set_prop_value(output,
> IGT_CONNECTOR_MAX_BPC, 10);
>  		igt_output_set_pipe(output, p);
> 
>  		if (is_intel_device(data->drm_fd) &&
> -		    !igt_max_bpc_constraint(&data->display, p, output, 10))
> +		    !igt_max_bpc_constraint(&data->display, p, output, 10)) {
> +			igt_info("Output %s: Doesn't support 10-bpc.\n",
> +				 igt_output_name(output));
>  			continue;
> +		}
> 
>  		data->color_depth = 10;
>  		data->drm_format = DRM_FORMAT_XRGB2101010;
> --
> 2.43.2