[i-g-t 2/4] tests/kms_dither: Add more logs to skips

Bhanuprakash Modem bhanuprakash.modem at intel.com
Tue Aug 13 05:38:43 UTC 2024


Debugging would be easier if we had logs available for
test failures and skips. This patch adds print statements
at crucial points to provide better insights.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
---
 tests/kms_dither.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/tests/kms_dither.c b/tests/kms_dither.c
index d8255f190..ce4172117 100644
--- a/tests/kms_dither.c
+++ b/tests/kms_dither.c
@@ -207,11 +207,17 @@ run_dither_test(data_t *data, int fb_bpc, int fb_format, int output_bpc)
 	for_each_connected_output(display, output) {
 		enum pipe pipe;
 
-		if (!is_supported(output))
+		if (!is_supported(output)) {
+			igt_info("Output %s: Doesn't support \"max bpc\" property.\n",
+				 igt_output_name(output));
 			continue;
+		}
 
-		if (igt_get_output_max_bpc(data->drm_fd, output->name) < output_bpc)
+		if (igt_get_output_max_bpc(data->drm_fd, output->name) < output_bpc) {
+			igt_info("Output %s: Doesn't support %d-bpc.\n",
+				 igt_output_name(output), output_bpc);
 			continue;
+		}
 
 		for_each_pipe(display, pipe) {
 			igt_output_set_pipe(output, pipe);
-- 
2.43.2



More information about the igt-dev mailing list