[i-g-t 2/4] tests/kms_dither: Add more logs to skips

[Samala, Pranay]

> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of
> Bhanuprakash Modem
> Sent: Tuesday, August 13, 2024 11:09 AM
> To: igt-dev at lists.freedesktop.org
> Cc: Modem, Bhanuprakash <bhanuprakash.modem at intel.com>
> Subject: [i-g-t 2/4] tests/kms_dither: Add more logs to skips
> 
> Debugging would be easier if we had logs available for test failures and skips. This
> patch adds print statements at crucial points to provide better insights.

This patch LGTM.

Reviewed-by: Pranay Samala <pranay.samala at intel.com>
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
> ---
>  tests/kms_dither.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_dither.c b/tests/kms_dither.c index d8255f190..ce4172117
> 100644
> --- a/tests/kms_dither.c
> +++ b/tests/kms_dither.c
> @@ -207,11 +207,17 @@ run_dither_test(data_t *data, int fb_bpc, int
> fb_format, int output_bpc)
>  	for_each_connected_output(display, output) {
>  		enum pipe pipe;
> 
> -		if (!is_supported(output))
> +		if (!is_supported(output)) {
> +			igt_info("Output %s: Doesn't support \"max bpc\"
> property.\n",
> +				 igt_output_name(output));
>  			continue;
> +		}
> 
> -		if (igt_get_output_max_bpc(data->drm_fd, output->name) <
> output_bpc)
> +		if (igt_get_output_max_bpc(data->drm_fd, output->name) <
> output_bpc) {
> +			igt_info("Output %s: Doesn't support %d-bpc.\n",
> +				 igt_output_name(output), output_bpc);
>  			continue;
> +		}
> 
>  		for_each_pipe(display, pipe) {
>  			igt_output_set_pipe(output, pipe);
> --
> 2.43.2