[PATCH i-g-t 1/2] tests/chamelium/kms_chamelium_hpd: don't unplug multiple times

[B, Jeevan]

From: Joshi, Kunal1 <kunal1.joshi at intel.com>
Sent: Monday, December 9, 2024 1:36 PM
To: B, Jeevan <jeevan.b at intel.com>; igt-dev at lists.freedesktop.org
Subject: Re: [PATCH i-g-t 1/2] tests/chamelium/kms_chamelium_hpd: don't unplug multiple times

Thanks Jeevan for taking a look,

Apart from this it looks good to me.
Reviewed-by: Jeevan B <jeevan.b at intel.com<mailto:jeevan.b at intel.com>>

> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org<mailto:igt-dev-bounces at lists.freedesktop.org>> On Behalf Of Kunal
> Joshi
> Sent: Thursday, December 5, 2024 3:11 PM
> To: igt-dev at lists.freedesktop.org<mailto:igt-dev at lists.freedesktop.org>
> Cc: Joshi, Kunal1 <kunal1.joshi at intel.com<mailto:kunal1.joshi at intel.com>>
> Subject: [PATCH i-g-t 1/2] tests/chamelium/kms_chamelium_hpd: don't
> unplug multiple times
>
> chamelium_reset_state will unplug all the ports, prevent unplugging multiple
> times
If this is fixing any issue ?? or Just a clean up ??
>
Yes  this should fix xe#3505,
Will add a Fixes tag, let me know if any other issues,
Will send all together in v2.

Thanks and Regards
Kunal Joshi
> Signed-off-by: Kunal Joshi <kunal1.joshi at intel.com<mailto:kunal1.joshi at intel.com>>
> ---
>  tests/chamelium/kms_chamelium_hpd.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/tests/chamelium/kms_chamelium_hpd.c
> b/tests/chamelium/kms_chamelium_hpd.c
> index 52e758087..76a691043 100644
> --- a/tests/chamelium/kms_chamelium_hpd.c
> +++ b/tests/chamelium/kms_chamelium_hpd.c
> @@ -329,10 +329,6 @@ static void
> test_hotplug_for_each_pipe(chamelium_data_t *data,
>                              data->ports, data->port_count);
>
>        igt_hpd_storm_set_threshold(data->drm_fd, 0);
> -     /* Disconnect if any port got connected */
> -     chamelium_unplug(data->chamelium, port);
> -     chamelium_wait_for_connector_after_hotplug(data, mon, port,
> -
> DRM_MODE_DISCONNECTED);
>
>        for_each_pipe(&data->display, pipe) {
>                igt_modeset_disable_all_outputs(&data->display);
> --
> 2.25.1
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/igt-dev/attachments/20241209/4c3dcd56/attachment-0001.htm>