[PATCH i-g-t 4/5] tests/kms_plane_scaling: Improvise the plane scaling BW issues
Naladala Ramanaidu
ramanaidu.naladala at intel.com
Mon Jul 15 15:46:27 UTC 2024
Anticipating bandwidth issues, we expect many tests to fail. To
address these failures, we will switch to the next lowest display
modes. Higher display modes will be identified as insufficient for
downscaling operations on plane scaling. As a solution, we
will implement a fix: when bandwidth is inadequate for current
modes, the system will automatically attempt the next lower
display mode.
Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala at intel.com>
---
tests/kms_plane_scaling.c | 82 +++++++++++++++++++--------------------
1 file changed, 40 insertions(+), 42 deletions(-)
diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 1702ec8c8..020d72953 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -582,54 +582,52 @@ static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
int w, h;
int width, height;
- mode = igt_output_get_mode(output);
-
- if (is_clip_clamp == true) {
- width = mode->hdisplay + 100;
- height = mode->vdisplay + 100;
- } else {
- width = get_width(mode, sf_plane1);
- height = get_height(mode, sf_plane1);
- }
-
- if (is_upscale) {
- w = width;
- h = height;
- } else {
- w = mode->hdisplay;
- h = mode->vdisplay;
+ for_each_connector_mode(output) {
+ mode = &output->config.connector->modes[j__];
+ if (is_upscale) {
+ w = get_width(mode, sf_plane1);
+ h = get_height(mode, sf_plane1);
+ } else {
+ if (is_clip_clamp == true) {
+ width = mode->hdisplay + 100;
+ height = mode->vdisplay + 100;
+ } else {
+ width = get_width(mode, sf_plane1);
+ height = get_height(mode, sf_plane1);
+ }
+ w = mode->hdisplay;
+ h = mode->vdisplay;
+ }
+ /*
+ * guarantee even value width/height to avoid fractional
+ * uv component in chroma subsampling for yuv 4:2:0 formats
+ */
+ w = ALIGN(w, 2);
+ h = ALIGN(h, 2);
+ igt_create_fb(display->drm_fd, w, h, pixel_format,
+ modifier, &d->fb[0]);
+ igt_plane_set_fb(plane, &d->fb[0]);
+ igt_fb_set_position(&d->fb[0], plane, 0, 0);
+ igt_fb_set_size(&d->fb[0], plane, w, h);
+ igt_plane_set_position(plane, 0, 0);
+
+ if (is_upscale)
+ igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
+ else
+ igt_plane_set_size(plane, width, height);
+
+ if (rot != IGT_ROTATION_0)
+ igt_plane_set_rotation(plane, rot);
+ commit_ret = igt_display_try_commit2(display, COMMIT_ATOMIC);
+ if (commit_ret == 0)
+ break;
}
- /*
- * guarantee even value width/height to avoid fractional
- * uv component in chroma subsampling for yuv 4:2:0 formats
- * */
- w = ALIGN(w, 2);
- h = ALIGN(h, 2);
-
- igt_create_fb(display->drm_fd, w, h, pixel_format, modifier, &d->fb[0]);
-
- igt_plane_set_fb(plane, &d->fb[0]);
- igt_fb_set_position(&d->fb[0], plane, 0, 0);
- igt_fb_set_size(&d->fb[0], plane, w, h);
- igt_plane_set_position(plane, 0, 0);
-
- if (is_upscale)
- igt_plane_set_size(plane, mode->hdisplay, mode->vdisplay);
- else
- igt_plane_set_size(plane, width, height);
-
- if (rot != IGT_ROTATION_0)
- igt_plane_set_rotation(plane, rot);
- commit_ret = igt_display_try_commit2(display, COMMIT_ATOMIC);
-
igt_plane_set_fb(plane, NULL);
igt_plane_set_position(plane, 0, 0);
cleanup_fbs(d);
-
igt_skip_on_f(commit_ret == -ERANGE || commit_ret == -EINVAL,
- "Unsupported scaling factor with fb size %dx%d\n",
- w, h);
+ "Unsupported scaling factor with fb size %dx%d\n", w, h);
igt_assert_eq(commit_ret, 0);
}
--
2.43.0
More information about the igt-dev
mailing list