[PATCH i-g-t 2/2] "tests/intel/xe_gt_freq: Fix freq_low_max test

Kamil Konieczny kamil.konieczny at linux.intel.com
Fri Jun 14 13:37:22 UTC 2024


Hi Badal,
On 2024-06-14 at 15:37:12 +0530, Badal Nilawar wrote:
> Intention of freq_low_max is to validate GuC PC flow when max freq set
> to less than min freq. Validating cur freq is enough as workloads are
> not being run.
> 
> Cc: Vinay Belgaumkar <vinay.belgaumkar at intel.com>
> Signed-off-by: Badal Nilawar <badal.nilawar at intel.com>

Instead of revert and fixing revert, please send one patch
and add there which one did you fixed.

> ---
>  tests/intel/xe_gt_freq.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/intel/xe_gt_freq.c b/tests/intel/xe_gt_freq.c
> index 24333612b..b3562181d 100644
> --- a/tests/intel/xe_gt_freq.c
> +++ b/tests/intel/xe_gt_freq.c
> @@ -277,7 +277,6 @@ static void test_freq_low_max(int fd, int gt_id)
>  	rpe = get_freq(fd, gt_id, "rpe");
>  
>  	igt_assert(get_freq(fd, gt_id, "cur") == rpe);
> -	igt_assert(get_freq(fd, gt_id, "act") == rpe);

Why ot writing comment here why "act" frequency is not checked?

Regards,
Kamil

>  }
>  
>  /**
> -- 
> 2.34.1
> 


More information about the igt-dev mailing list