[PATCH i-g-t v3 5/7] benchmarks/kms_fb_stress: Don't paint the FB's if the format is DRM_FORMAT_RGB565

Pekka Paalanen pekka.paalanen at collabora.com
Wed Mar 20 15:36:45 UTC 2024


On Thu, 07 Mar 2024 16:41:07 -0300
Arthur Grillo <arthurgrillo at riseup.net> wrote:

> Cairo does not fully support the RGB565 due to some stride issues.
> So, don't paint the FB's if the format is DRM_FORMAT_RGB565.

Cairo, as it is based on Pixman, requires stride to be divisible by
sizeof(uint32_t). Pixman makes use of that requirement to go faster.

It probably wouldn't hurt if VKMS happened to have the same convention?

Anyway, it would be better to test the stride, not format. Maybe IGT
should grow a function to check if it can paint with a specific stride
& format?

> 
> Signed-off-by: Arthur Grillo <arthurgrillo at riseup.net>
> ---
>  benchmarks/kms_fb_stress.c | 55 ++++++++++++++++++++++++++++++++++------------
>  1 file changed, 41 insertions(+), 14 deletions(-)

Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/igt-dev/attachments/20240320/f2c10c79/attachment.sig>


More information about the igt-dev mailing list