[PATCH i-g-t v3 5/7] benchmarks/kms_fb_stress: Don't paint the FB's if the format is DRM_FORMAT_RGB565

[Arthur Grillo]

On 20/03/24 12:36, Pekka Paalanen wrote:
> On Thu, 07 Mar 2024 16:41:07 -0300
> Arthur Grillo <arthurgrillo at riseup.net> wrote:
> 
>> Cairo does not fully support the RGB565 due to some stride issues.
>> So, don't paint the FB's if the format is DRM_FORMAT_RGB565.
> 
> Cairo, as it is based on Pixman, requires stride to be divisible by
> sizeof(uint32_t). Pixman makes use of that requirement to go faster.
> 
> It probably wouldn't hurt if VKMS happened to have the same convention?

By not supporting too? Or converting the plane to have strides divisible
by sizeof(uint32_t) before doing the format conversion?

> 
> Anyway, it would be better to test the stride, not format. Maybe IGT
> should grow a function to check if it can paint with a specific stride
> & format?

If the stride issue is the only thing that decides if a format can be
painted, I think I can create this function.

Best Regards,
~Arthur Grillo

> 
>>
>> Signed-off-by: Arthur Grillo <arthurgrillo at riseup.net>
>> ---
>>  benchmarks/kms_fb_stress.c | 55 ++++++++++++++++++++++++++++++++++------------
>>  1 file changed, 41 insertions(+), 14 deletions(-)
> 
> Thanks,
> pq