[PATCH i-g-t] tests/kms_plane_scaling: Add logs to skips

Reddy Guddati, Santhosh santhosh.reddy.guddati at intel.com
Mon Jan 6 09:42:04 UTC 2025


Hi Pranay,

________________________________
From: igt-dev <igt-dev-bounces at lists.freedesktop.org> on behalf of Pranay Samala <pranay.samala at intel.com>
Sent: Friday, January 3, 2025 4:04 PM
To: igt-dev at lists.freedesktop.org <igt-dev at lists.freedesktop.org>
Cc: B S, Karthik <karthik.b.s at intel.com>; Sharma, Swati2 <swati2.sharma at intel.com>; Lattannavar, Sameer <sameer.lattannavar at intel.com>; Samala, Pranay <pranay.samala at intel.com>
Subject: [PATCH i-g-t] tests/kms_plane_scaling: Add logs to skips

Having some logs for test failures & skips would
make debugging much easier.

Signed-off-by: Pranay Samala <pranay.samala at intel.com>
---
 tests/kms_plane_scaling.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index c8c9aee31..2a8867822 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -1577,6 +1577,9 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
                                                                        kmstest_pipe_name(pipe), igt_output_name(output))
                                                                 intel_max_source_size_test(&data, pipe, output, mode,
                                                                                            intel_paramtests[index].planesize);
+                                               } else {
+                                                       igt_info("Unable to find the lowest " \
+                                                                "refresh rate mode\n");

Imho, It would be good to add the output name and pipe name something like below, otherwise LGTM.
  igt_info("Unable to find a mode with the lowest refresh rate for
            output %s on pipe %s\n",
            igt_output_name(output), kmstest_pipe_name(pipe));

                                                 }
                                                 continue;
                                         }
--
2.34.1

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/igt-dev/attachments/20250106/791139cb/attachment-0001.htm>


More information about the igt-dev mailing list