[PATCH i-g-t 1/2] tests/intel/kms_dp_link_training: do modeset before retrainig

[Joshi, Kunal1]

Hello Jeevan,


> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Kunal
> Joshi
> Sent: Thursday, February 27, 2025 6:01 PM
> To: igt-dev at lists.freedesktop.org
> Cc: Joshi, Kunal1 <kunal1.joshi at intel.com>
> Subject: [PATCH i-g-t 1/2] tests/intel/kms_dp_link_training: do modeset
> before retrainig
>
> Retraining can be done on enabled output.
> Fix test to do modeset before retraining.
>
> Fixes: 983ffca5ff96fd67c937691337f4488e28948aa7
> Signed-off-by: Kunal Joshi <kunal1.joshi at intel.com>
> ---
>  tests/intel/kms_dp_link_training.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/intel/kms_dp_link_training.c
> b/tests/intel/kms_dp_link_training.c
> index f00376614..33e690a60 100644
> --- a/tests/intel/kms_dp_link_training.c
> +++ b/tests/intel/kms_dp_link_training.c
> @@ -233,6 +233,7 @@ static bool run_link_rate_test(data_t *data, bool mst,
> bool uhbr)
>
>        igt_display_reset(&data->display);
>        igt_reset_link_params(data->drm_fd, data->output);
> +     do_modeset(data, mst);
We are performing do_modeset twice any idea why ??

Right, that's a miss from myside.
Will shuffle instead of adding twice.

Thanks and Regards
Kunal Joshi
>
>        /* Retrain at default/driver parameters */
>        igt_force_link_retrain(data->drm_fd, data->output,
> RETRAIN_COUNT);
Here also its there.
> --
> 2.25.1

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/igt-dev/attachments/20250303/7928e052/attachment.htm>