[immodule-qt] BC patch for Qt 3.3.2

[YamaKen]

Hi Lars, thanks for the advice.

At Fri, 23 Jul 2004 11:34:33 +0200,
Lars Knoll wrote:
> -static char    *ximServer	= 0;		// XIM Server will connect to
> +char    *ximServer	= 0;		// XIM Server will connect to
> 
> This would add an exported ximServer symbol to the Qt lib, that might lead to 
> clashes if applications use the same symbol name. In general all variables or 
> methods that are not static have to be prefixed with qt_. So it would be best 
> to rename it to qt_ximServer.
(snip)
> Same as above. Please rename to qt_xim_preferred_style, etc.

I regret that I had not take attention with it...

All of the variables are renamed. And I have checked other
symbol space pollution with following script. There is no other
pollution by the immodule patch.

objdump -TC /usr/X11R6/lib/libqt-mt.so.3.3.2 | egrep -v '(QUType|\*(UND|ABS)\*|        (Q|qt_|std::|TT_|Load_|Free_|operator|typeinfo|vtable|non-virtual|(void )?q[A-Z]))' | sort

> +    defaultIM = settings.readEntry( "/qt/DefaultInputMethod", QObject::trUtf8
> ( "XIM" ) );
> 
> I don't think you should translate the default for the config entry, so the 
> line should rather be:
> 
> +    defaultIM = settings.readEntry( "/qt/DefaultInputMethod", "XIM" );

Right. I've fixed.

The changes have been committed in the trunk. But the svn
repository has been broken, so I can't commit it into the BC
branch. I'll commit it after recovery.

-------------------------------
YamaKen  yamaken at bp.iij4u.or.jp