[immodule-qt] [PATCH] Surrounding text

[Daisuke Kameda]

Kazuki Ohta <mover at hct.zaq.ne.jp> wrote:

> Hi, Daisuke.
> 
> I've created Surrounding Text patch for Qt4 (attached).
> It's very easy to port because whole Anuradha's code can be reused except 
> QTextEdit's part. So, please check QTextEdit::imGetSurrounding() and 
> QTextEdit::imDeleteSurrounding(). I don't have confidence around these 
> functions.

Thank you for making this patch. I have checked it.


There are question about the next line of QTextEdit::imDeleteSurrounding().
"+    d->cursor.setPosition( prevCursorPos, QTextCursor::KeepAnchor );"

Why is the first argument set to "prevCursorPos" instead of "prevCursorPos+offset"?
And, Why is the second argument set to "KeepAnchor" instead of "MoveAnchor"?


Moreover, It is better to change "TRUE" to "true".

I think that others are satisfactory.


-- 
Daisuke Kameda <kaminmat at cc.rim.or.jp>