[immodule-qt] [PATCH] Surrounding text

[Kazuki Ohta]

Hi, Daisuke.
Thank you for your review!

> Kazuki Ohta <mover at hct.zaq.ne.jp> wrote:
> > Hi, Daisuke.
> >
> > I've created Surrounding Text patch for Qt4 (attached).
> > It's very easy to port because whole Anuradha's code can be reused except
> > QTextEdit's part. So, please check QTextEdit::imGetSurrounding() and
> > QTextEdit::imDeleteSurrounding(). I don't have confidence around these
> > functions.
>
> There are question about the next line of QTextEdit::imDeleteSurrounding().
> "+    d->cursor.setPosition( prevCursorPos, QTextCursor::KeepAnchor );"
>
> Why is the first argument set to "prevCursorPos" instead of
> "prevCursorPos+offset"?
Oops.This is my silly mistake.
fixed.

> And, Why is the second argument set to "KeepAnchor" 
> instead of "MoveAnchor"?
fixed. Thank you!

> Moreover, It is better to change "TRUE" to "true".
fixed.

Fixed version of the patch is attached.

regards.
---------------------------------
Move the worl:D!
Kazuki Ohta : mover at hct.zaq.ne.jp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: qt-4.0-tp1-im-surround.patch
Type: text/x-diff
Size: 4969 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/immodule-qt/attachments/20041010/ed8f79a5/attachment.patch