[PATCH libinputmapper 11/13] autogen: support out-of-tree builds

[David Herrmann]

Hi

On Tue, Sep 3, 2013 at 12:09 AM, Peter Hutterer
<peter.hutterer at who-t.net> wrote:
> On Sun, Sep 01, 2013 at 06:08:05PM +0200, David Herrmann wrote:
>> Hi
>>
>> On Wed, Aug 28, 2013 at 3:00 AM, Peter Hutterer
>> <peter.hutterer at who-t.net> wrote:
>> > Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
>> > ---
>> >  autogen.sh | 11 ++++++++++-
>> >  1 file changed, 10 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/autogen.sh b/autogen.sh
>> > index 7edcbb9..65a6fe1 100755
>> > --- a/autogen.sh
>> > +++ b/autogen.sh
>> > @@ -1,8 +1,17 @@
>> >  #!/bin/sh
>> >  set -e
>> > +
>> > +srcdir=`dirname $0`
>> > +test -z "$srcdir" && srcdir=.
>> > +
>> > +origdir=`pwd`
>> > +cd $srcdir
>> > +
>> >  mkdir -p m4
>> >  autoreconf -is --force
>>
>> Ugh, so you still call "autoreconf" in the srcdir. Any reason why
>> out-of-tree builds would ever call "./autogen.sh"?
>
> use-case here:
>     mkdir /path/to/build-dir
>     cd /path/to/build-dir
>     /path/to/srcdir/autogen.sh
>
> I used a setup like that a while ago for hw-dependent builds from the same
> tree, back when I was running i686 and x86_64 distributions on the same
> machine.
>
> the above is copied from the xorg autogen.sh, they're all the same. and they
> are largely because X had to be built with a script to get all modules done
> in the right order. git history isn't too clear here to really tell why,
> tbh.
>
>> We already support VPATH builds from tarballs. I don't know whether it
>> makes sense to support them from clean git-trees.
>
> at least in Fedora we don't take tarballs and run configure but autotool
> them during the rpm build. so the srcdir/builddir separation in the tarball
> wouldn't help us here. though we don't run autogen.sh either and not sure if
> anyone is at this point.
>
> autogen.sh is a weird use-case in general since it doesn't do that much to
> begin with for us. so feel free to drop it, but I suspect merging this patch
> means you won't have to ever think about autogen.sh again ;)

Yepp, I'm convinced. Pushed.

Thanks
David