[PATCH libevdev] build: remove -fstack-protector

[Benjamin Tissoires]

On Mon, Sep 9, 2013 at 3:09 PM, David Herrmann <dh.herrmann at gmail.com> wrote:
> If gcc is built without libssp support, it loudly fails linking due to
> missing __stack_chk_*() helpers. Unfortunately, gcc isn't smart enough to
> disable it automatically.
>
> systemd recently got a CC_CHECK_FLAG_APPEND helper to work around such
> issues:
>   http://cgit.freedesktop.org/systemd/systemd/tree/m4/attributes.m4
>
> I didn't want to add it now, so let's just drop -fstack-protector. If we
> want it, we can try adding it later again.
>
> Reported-by: Giovanni Campagna
> Signed-off-by: David Herrmann <dh.herrmann at gmail.com>
> ---
> Hi Peter
>
> This actually breaks the ostree build.gnome.org build, so it'd be nice to see
> this applied upstream. It's just a partial revert of:
>   43752ec17d09b132621a86f5cbc546ca6ab9e977

I would love to see this hash referred in the actual commit message (I
remember recently some complains from Linus about a revert patch in
which no mention was made on the revert...)

>
> Should be good to go.

I'll let Peter decide, but this flags allows us at least once to find
a nasty bug in xf86-drv-input-synaptics[1] (or whatever it is called).
So I would say we can remove it, but it would still be great to have a
way to use it if gcc supports it, otherwise these bugs are really hard
to spot.

Cheers,
Benjamin

[1] http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics/commit/?id=7cc0ebf0858ebb505d933839f25bb269a8cdb764

> Thanks
> David
>
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index b2fc7ff..24a9356 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -47,7 +47,7 @@ AM_CONDITIONAL(BUILD_TESTS, [test "x$HAVE_CHECK" = "xyes"])
>
>
>  if test "x$GCC" = "xyes"; then
> -       GCC_CFLAGS="-Wall -Wextra -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -fvisibility=hidden -pipe -fno-common -fno-strict-aliasing -ffunction-sections -fdata-sections -fstack-protector -fno-strict-aliasing -fdiagnostics-show-option -fno-common"
> +       GCC_CFLAGS="-Wall -Wextra -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -fvisibility=hidden -pipe -fno-common -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-strict-aliasing -fdiagnostics-show-option -fno-common"
>  fi
>  AC_SUBST(GCC_CFLAGS)
>
> --
> 1.8.4
>
> _______________________________________________
> Input-tools mailing list
> Input-tools at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/input-tools