[PATCH libevdev] build: remove -fstack-protector

David Herrmann dh.herrmann at gmail.com
Mon Sep 9 07:06:21 PDT 2013


On Mon, Sep 9, 2013 at 4:00 PM, Benjamin Tissoires
<benjamin.tissoires at gmail.com> wrote:
> On Mon, Sep 9, 2013 at 3:09 PM, David Herrmann <dh.herrmann at gmail.com> wrote:
>> If gcc is built without libssp support, it loudly fails linking due to
>> missing __stack_chk_*() helpers. Unfortunately, gcc isn't smart enough to
>> disable it automatically.
>> systemd recently got a CC_CHECK_FLAG_APPEND helper to work around such
>> issues:
>>   http://cgit.freedesktop.org/systemd/systemd/tree/m4/attributes.m4
>> I didn't want to add it now, so let's just drop -fstack-protector. If we
>> want it, we can try adding it later again.
>> Reported-by: Giovanni Campagna
>> Signed-off-by: David Herrmann <dh.herrmann at gmail.com>
>> ---
>> Hi Peter
>> This actually breaks the ostree build.gnome.org build, so it'd be nice to see
>> this applied upstream. It's just a partial revert of:
>>   43752ec17d09b132621a86f5cbc546ca6ab9e977
> I would love to see this hash referred in the actual commit message (I
> remember recently some complains from Linus about a revert patch in
> which no mention was made on the revert...)

Indeed. I've sent v2.

>> Should be good to go.
> I'll let Peter decide, but this flags allows us at least once to find
> a nasty bug in xf86-drv-input-synaptics[1] (or whatever it is called).
> So I would say we can remove it, but it would still be great to have a
> way to use it if gcc supports it, otherwise these bugs are really hard
> to spot.

That's why I added it. Nice to see it helped. I just wanted to fix
build for ostree now. I want Peter's opinion on the systemd-link I
posted in the commit-msg. If he is fine with it, I will add the macro
which allows us to add any compiler/ld flags we want.

Thanks for review

More information about the Input-tools mailing list