[PATCH evemu] test: test-evemu-create.c: declare check_evemu_read() static

Peter Hutterer peter.hutterer at who-t.net
Mon Sep 18 22:15:39 UTC 2017


On Mon, Sep 18, 2017 at 08:42:08PM +0200, Martin Kepplinger wrote:
> check_evemu_read() is only use locally in this module. It should be static.
> 
> Signed-off-by: Martin Kepplinger <martink at posteo.de>
> ---
>  test/test-evemu-create.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/test-evemu-create.c b/test/test-evemu-create.c
> index 3c79fd0..d5238e5 100644
> --- a/test/test-evemu-create.c
> +++ b/test/test-evemu-create.c
> @@ -67,7 +67,7 @@ static void println(int fd, int flags, const char *format, ...)
>  	va_end(args);
>  }
>  
> -void check_evemu_read(int fd, const char *file, enum flags flags)
> +static void check_evemu_read(int fd, const char *file, enum flags flags)
>  {
>  	FILE *fp;
>  	struct evemu_device *dev;
> -- 
> 2.11.0

pushed, thanks

fwiw, you don't need to add the filename to the git subject, a category is
enough (e.g. 'test' or 'evemu-record' or just 'tools'). The filename is
included in the diff anyway and often you can't just change a single file to
get a change in. The category prefix we use is just to make it easier to get
a grasp on what's been changing in the git log.

Cheers,
   Peter


More information about the Input-tools mailing list