[PATCH evemu] test: test-evemu-create.c: declare check_evemu_read() static

[Martin Kepplinger]

Am 19.09.2017 00:15 schrieb Peter Hutterer:
> On Mon, Sep 18, 2017 at 08:42:08PM +0200, Martin Kepplinger wrote:
>> check_evemu_read() is only use locally in this module. It should be 
>> static.
>> 
>> Signed-off-by: Martin Kepplinger <martink at posteo.de>
>> ---
>>  test/test-evemu-create.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/test/test-evemu-create.c b/test/test-evemu-create.c
>> index 3c79fd0..d5238e5 100644
>> --- a/test/test-evemu-create.c
>> +++ b/test/test-evemu-create.c
>> @@ -67,7 +67,7 @@ static void println(int fd, int flags, const char 
>> *format, ...)
>>  	va_end(args);
>>  }
>> 
>> -void check_evemu_read(int fd, const char *file, enum flags flags)
>> +static void check_evemu_read(int fd, const char *file, enum flags 
>> flags)
>>  {
>>  	FILE *fp;
>>  	struct evemu_device *dev;
>> --
>> 2.11.0
> 
> pushed, thanks
> 
> fwiw, you don't need to add the filename to the git subject, a category 
> is
> enough (e.g. 'test' or 'evemu-record' or just 'tools'). The filename is
> included in the diff anyway and often you can't just change a single 
> file to
> get a change in. The category prefix we use is just to make it easier 
> to get
> a grasp on what's been changing in the git log.
> 

I see, it indeed feels wrong to put filenames in the headline. Btw, I 
don't have
any planned changes now. You can never know, but just in case... for 
your
release plannings.

    a355c9b evemu-record.c: Fix evemu-describe writing to output file

fixes a real user interface error after all.

thanks

               martin