[Bug 71870] Metro: Last Light rendering issues

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=71870

--- Comment #10 from Paul Berry <stereotype441 at gmail.com> ---
(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #7)
>  
> > Tapani, can you please try running Metro again with
> > http://lists.freedesktop.org/archives/mesa-dev/2013-November/049081.html
> > applied?  I'm hoping that this will fix the crash issue and take you back to
> > the state where there are just rendering issues.
> 
> Yes, just confirmed that this patch fixes the crash

Ok, the crash is fixed by commit 2714ca81b9bad3dec3894fac97f34502c80b1697
Author: Paul Berry <stereotype441 at gmail.com>
Date:   Mon Nov 25 08:03:24 2013 -0800

    i965/gs: Properly skip GS binding table upload when no GS active.

    Previously, in brw_gs_upload_binding_table(), we checked whether
    brw->gs.prog_data was NULL in order to determine whether a geometry
    shader was active.  This didn't work: brw->gs.prog_data starts off as
    NULL, but it is set to non-NULL when a geometry shader program is
    built, and then never set to NULL again.  As a result, if we called
    brw_gs_upload_binding_table() while there was no geometry shader
    active, but a geometry shader had previously been active, it would
    refer to a stale (and possibly freed) prog_data structure.

    This patch fixes the problem by modifying
    brw_gs_upload_binding_table() to use the proper technique to determine
    whether a geometry shader is active: by checking whether
    brw->geometry_program is NULL.

    This fixes the crash reported in comment 2 of bug 71870 (the incorrect
    rendering remains, however).    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=71870

    Cc: mesa-stable at lists.freedesktop.org

    Reviewed-by: Chris Forbes <chrisf at ijw.co.nz>
    Reviewed-by: Eric Anholt <eric at anholt.net>
    Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20131126/93dac950/attachment.html>