[Bug 76394] [IVB/HSW] ogl-samples: gl-320-primitive-shading render error (missing all colors)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=76394

Kenneth Graunke <kenneth at whitecape.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Kenneth Graunke <kenneth at whitecape.org> ---
Committed as:

commit 6d0e30c6a332de9ea7ab00e1fd303df2fb337c64
Author: Iago Toral Quiroga <itoral at igalia.com>
Date:   Fri Apr 4 15:11:15 2014 +0200

    glsl: Properly handle blocks that define the same field name.

    Currently we can have name space collisions between blocks that define the
same
    fields. For example:

    in block
    {
        vec4 Color;
    } In[];

    out block
    {
        vec4 Color;
    } Out;

    These two blocks will assign the same interface name (block.Color) to the
Color
    field in flatten_named_interface_blocks_declarations.cpp, leading to havoc.
    This was breaking badly the gl-320-primitive-shading test from ogl-samples.

    The patch uses the block instance name to avoid collisions, producing names
    like block.In.Color and block.Out.Color to avoid the name clash.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76394
    Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

Marking fixed.  But...I'm not sure if those errors are expected.  If not, we
should probably reopen this (and change the title)...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20140416/9e7e6103/attachment.html>