[Bug 74143] [SNB Regression]Piglit/glx_GLX_ARB_create_context_current_with_no_framebuffer segfault

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=74143

Kristian Høgsberg <krh at bitplanet.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |idr at freedesktop.org

--- Comment #5 from Kristian Høgsberg <krh at bitplanet.net> ---
Adding irc discussion with Ian here:

12:15 < idr> krh: In the None drawable case, both read and draw must be None.  
             Is that checked somewhere?
...
12:29 < krh> idr: seems like something we should do in MakeContextCurrent, but 
             I don't see it there
12:30 < krh> idr: if only one of them is NULL, the dri driver will crash
12:30 < idr> I'm also not sure how we'll enforce the "...and the OpenGL version 
             supported by <ctx> is 3.0 or greater." requirement. :(
12:30 < idr> Now or with your patch?
12:31 < krh> without my patch, the driver would never see a NULL draw/readable
12:32 < krh> so it wouldn't hit that case

I think further checking and validation of the extension makes sense, but it's
orthogonal to fixing this regression.  Once change in behavior is that without
the patch in comment 4, passing a None and a non-None drawable to
glxMakeContext Current I get

X Error of failed request:  BadDrawable (invalid Pixmap or Window parameter)
  Major opcode of failed request:  152 (DRI2)
  Minor opcode of failed request:  3 (DRI2CreateDrawable)
  Resource id in failed request:  0x0
  Serial number of failed request:  35
  Current serial number in output stream:  37

with the patch we segfault instead.

So more work is needed to better check input, but that's not a new problem. 
Unless Ian objects, I'll commit this tomorrow.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20140206/54374007/attachment.html>