[Bug 75172] intel_mipmap_tree.c:728:7: error: void function 'intel_update_winsys_renderbuffer_miptree' should not return a value [-Wreturn-type]

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=75172

Ian Romanick <idr at freedesktop.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|idr at freedesktop.org         |eric at anholt.net
                 CC|                            |idr at freedesktop.org

--- Comment #1 from Ian Romanick <idr at freedesktop.org> ---
I see two problems in the function that prevent me from proposing the obvious,
trivial fix.

1. This looks like an error case, and the caller should be signaled.  It looks
like previous to 019560c1 the caller was signaled, but ignored it.

2. It looks like there's a potential leak of irb->singlesample_mt, but I don't
know the surrounding code well enough to be sure.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20140218/a576135f/attachment.html>